Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processingData slot is overwritten by initialize,MSnSet #264

Closed
sgibb opened this issue Sep 26, 2017 · 1 comment · Fixed by #266
Closed

processingData slot is overwritten by initialize,MSnSet #264

sgibb opened this issue Sep 26, 2017 · 1 comment · Fixed by #266

Comments

@sgibb
Copy link
Collaborator

sgibb commented Sep 26, 2017

Currently initialize overwrites the processingData slot of MSnSet objects (inherit from pSet). Is that expected?

.Object@processingData <- new("MSnProcess")

That's why something like this is necessary:

msnset <- new("MSnSet",
qual = data.frame(.qual),
exprs = .exprs,
experimentData = experimentData(object),
phenoData = .phenoData,
featureData = .featureData,
annotation = "No annotation")
## copying processingData
msnset@processingData <- object@processingData

IMHO the following should work:

new("MSnSet", processingData=new("MSnProcess", processing="Created"))

Is there any reason for overwriting the processingData slot?

@lgatto
Copy link
Owner

lgatto commented Sep 27, 2017

No, there isn't any good reason indeed, and a patch would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants