Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong MS OBO VC terms used #360

Closed
jorainer opened this issue Sep 20, 2018 · 3 comments
Closed

Wrong MS OBO VC terms used #360

jorainer opened this issue Sep 20, 2018 · 3 comments

Comments

@jorainer
Copy link
Collaborator

Sorry for pushing this (6c7bdb7) directly to master. I had used wrong CV terms for baseline correction and smoothing. Eventually also something to fix in RELEASE_#_7?
@lgatto
Copy link
Owner

lgatto commented Sep 21, 2018

backported and pushed to devel branch.

@lgatto lgatto closed this as completed Sep 21, 2018
jorainer added a commit that referenced this issue Sep 21, 2018
@jorainer
Fix unit tests (issue #360)
7b9eb89
@jorainer
Copy link
Collaborator Author

Sorry - did forget to adapt the unit test. Fixed now in the latest commit to master (again sorry).

@jorainer jorainer reopened this Sep 21, 2018
@lgatto
Copy link
Owner

lgatto commented Sep 21, 2018

No worries. Pushed to 2.7.7 on github (bumped to 2.7.8) and Bioc devel and backported to version 2.6.4 in release.

@lgatto lgatto closed this as completed Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lgatto @jorainer