featureCV ignores its na.rm argument #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating the
MSnSet
s for the synapter objects I recognizedNA
s in theCV
column. TheNA
s even survivena.rm=TRUE
:MWE:
expected output:
I have rewritten the
featureCV
to fix this bug and to speed up the calculation a little bit (because of less loops).I opened this PR because there are some failing unit tests (because my
pRolocdata
is too old) but I can't download a newer version now. Maybe you could have a look and run the tests.