Fix declarations of centroided/smoothed setters for OnDiskMSnExp objects #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With current R-devel (R 4.4), trying to install MSnBase <= 2.25.2 fails
with error messages complaining about the declarations of the centroided<-
and smoothed<- methods for OnDiskMSnExp objects. The complain is:
arguments ('value') after '...' in the generic must appear in
the method, in the same place at the end of the argument list
This commit fixes the method delcarations so that they are compatible
with R >= 4.4.
|
Merci beacoup! And sorry for the hassle. |
|
I have pushed this to devel on Bioc too. |
|
Merci Laurent ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salut Laurent,
With current R-devel (R 4.4), trying to install MSnbase <= 2.25.2 fails with error messages complaining about the declarations of the
centroided<-andsmoothed<-methods for OnDiskMSnExp objects. The complain is:We've been notified by R-core that this breaks many CRAN packages that depend directly or indirectly on MSnbase when using the latest R devel.
This commit fixes the method delcarations so that they are compatible with R >= 4.4.
Best,
H.