Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move XML to Suggests #600

Merged
merged 1 commit into from Mar 14, 2024
Merged

refactor: move XML to Suggests #600

merged 1 commit into from Mar 14, 2024

Conversation

jorainer
Copy link
Collaborator

This PR moves the XML package from Imports to Suggests and removes the import from the NAMESPACE. Package version was not bumped.

@jorainer jorainer requested a review from lgatto March 13, 2024 15:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.49%. Comparing base (efd48e3) to head (505baf1).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   71.49%   71.49%           
=======================================
  Files          78       78           
  Lines        8149     8149           
=======================================
  Hits         5826     5826           
  Misses       2323     2323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jorainer
Copy link
Collaborator Author

thanks for checking. I leave merging and pushing to BioC (and bumping version) to you @lgatto

@lgatto lgatto merged commit ba84422 into master Mar 14, 2024
8 checks passed
@lgatto
Copy link
Owner

lgatto commented Mar 14, 2024

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants