Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cholesky decomposition fix #124

Closed
lgatto opened this issue Nov 30, 2018 · 4 comments
Closed

Cholesky decomposition fix #124

lgatto opened this issue Nov 30, 2018 · 4 comments
Assignees

Comments

@lgatto
Copy link
Owner

lgatto commented Nov 30, 2018

@ococrook - I saw the cholesky-fix branch. Thank you.

Do you think this warrants a warning, or would a simple message not suffice. Also, whether it's a message or warning, could you refer the user to the documentation, and add a paragraph with a bit of explanation.

@ococrook
Copy link
Collaborator

Yes, a message is probably sufficient. Should I replace warning(...) with message(...)?

When you refer to documentation - do you mean the rd file or the vingette (or Both)?

@lgatto
Copy link
Owner Author

lgatto commented Nov 30, 2018

Yes, use message().

Re documentation, the rd file is enough, especially as users will be directed to it when the fix kicks in.

@ococrook
Copy link
Collaborator

great, pull request made!

@lgatto
Copy link
Owner Author

lgatto commented Nov 30, 2018

Closing, as PR #125 has been merged.

@lgatto lgatto closed this as completed Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants