Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with "Cmder" terminal on windows #2

Closed
Aaronmacaron opened this issue Oct 18, 2016 · 6 comments
Closed

Not working with "Cmder" terminal on windows #2

Aaronmacaron opened this issue Oct 18, 2016 · 6 comments
Labels

Comments

@Aaronmacaron
Copy link

If i set "cmder" (a quite popular cmd alternative on windows) as the terminal application i get this error message:

screenshot

Looks like it's passing some weird parameters to cmder.

@lgeiger
Copy link
Owner

lgeiger commented Oct 19, 2016

Thanks for trying it out!

Does it work with the default default terminal (cmd.exe)?

I'm not working with windows but I can test it with Cmder next week.

@Aaronmacaron
Copy link
Author

Yes, with cmd it's working perfectly fine.
I tested it with another terminal called "powershell". It prints following error message and then closes immediately:
test

@lgeiger
Copy link
Owner

lgeiger commented Oct 19, 2016

Thanks a lot for investigating. I'm not a windows user so any feedback is really appreciated.

That error message helps a lot. It looks like the /k option is only available for cmd.exe. I have to figure out how to support different terminals on windows.

If you are interested in helping this is the line we have to change.

Aaronmacaron pushed a commit to Aaronmacaron/term-launcher that referenced this issue Oct 19, 2016
@lgeiger lgeiger added the bug label Oct 20, 2016
@lgeiger lgeiger closed this as completed Oct 22, 2016
@felixholub
Copy link

I'm still seeing the error from the first post. So has this been solved and I'm doing something wrong?

@Aaronmacaron
Copy link
Author

This isn't a problem with hydrogen-launcher but with the dependency https://github.com/nteract/term-launcher . I fixed the problem in nteract/term-launcher#18 . If this gets merged we must update the version of term-launcher to make use of the fix.

@Aaronmacaron
Copy link
Author

@lgeiger the dependency to term-launcher should be updated to v0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants