Skip to content

Commit

Permalink
Support the workflow under Windows. google#9
Browse files Browse the repository at this point in the history
I found and fixed the first file/path issue, while running j2cl native with Windows 10 ... added the following fix ".replace('\\', '/')" here "com.google.j2cl.generator.OutputGeneratorStage#generateOutputs:87"

String typeRelativePath = getRelativePath(type).replace('\\', '/');

Not sure if this fix is well placed, but is corrects the issue (looking up an windows path in a map with unix paths)...
  • Loading branch information
lgemeinhardt committed Jan 22, 2019
1 parent 346935e commit b1db6de
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -84,7 +84,7 @@ public void generateOutputs(List<CompilationUnit> j2clCompilationUnits) {
new JavaScriptImplGenerator(problems, declareLegacyNamespace, type);

// If the java type contains any native methods, search for matching native file.
String typeRelativePath = getRelativePath(type);
String typeRelativePath = getRelativePath(type).replace('\\', '/');
String typeAbsolutePath =
FrontendUtils.getJavaPath(getAbsolutePath(j2clCompilationUnit, type));

Expand Down

0 comments on commit b1db6de

Please sign in to comment.