fix: Wait for an instance of a subclass of Promise in Promise.all #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
dylanahsmith
added a commit
that referenced
this pull request
Feb 11, 2016
fix: Wait for an instance of a subclass of Promise in Promise.all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eapache for review
Problem
I used
obj.instance_of?(Promise)in Promise.all to check for promises in the input, but that only returns true if the class of the object is equal to Promise, rather than supporting a subclass of Promise as I intended.I actually normally just use
.is_a?but mutation coverage testing didn't like that, and I thought the only difference between the two was that.instance_of?doesn't work with modules. But really it wanted me to test with subclasses.Solution
Change
.instance_of?to.is_a?and add a regression test.