Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite nbtutor code #44

Merged
merged 14 commits into from
Jul 29, 2021
Merged

Rewrite nbtutor code #44

merged 14 commits into from
Jul 29, 2021

Conversation

lgpage
Copy link
Owner

@lgpage lgpage commented Mar 7, 2021

Todo:

  • Update CI
  • Fix lines not redrawing on toggle visualization
  • Redo usage.gif
  • Update log level (suppress debug)

Close #43

@lgpage
Copy link
Owner Author

lgpage commented Mar 7, 2021

Hi @Naereen
If you have some time free, mind giving this a once over and maybe a try your side :)
The DEVELOP.md file should be update to date to explain how to get it up and running locally, if not please let me know and I can fill in the gaps or make things clearer

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@88f6cc5). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #44   +/-   ##
=========================================
  Coverage          ?   91.29%           
=========================================
  Files             ?      103           
  Lines             ?     1712           
  Branches          ?       57           
=========================================
  Hits              ?     1563           
  Misses            ?      119           
  Partials          ?       30           

@Naereen
Copy link

Naereen commented Mar 8, 2021

Hi @Naereen
If you have some time free, mind giving this a once over and maybe a try your side :)
The DEVELOP.md file should be update to date to explain how to get it up and running locally, if not please let me know and I can fill in the gaps or make things clearer

Hi there.
I see that this file talks about Angular and other things like this, to be honest I won't have time to download and install the requirements to build the extension locally.

But by using a setup.py file here on GitHub, it's possible to install a pip package which is not yet updated on pypi.org, by using

pip install git+https://github.com/lgpage/nbtutor/

If you want I could try to do this (in a virtualenv) when your next version seems ready, but before you deploy it to Pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite nbtutor code
2 participants