Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data in the package. Selecting Units #25

Closed
schoolAccountMajaG opened this issue Jun 12, 2019 · 16 comments
Closed

Data in the package. Selecting Units #25

schoolAccountMajaG opened this issue Jun 12, 2019 · 16 comments
Milestone

Comments

@schoolAccountMajaG
Copy link
Collaborator

Data for units are also available for 2011 but the vignette does not mention it. Many of the units do not have stack height data. Why? Is it feasible for us to fill these missing values?

@schoolAccountMajaG
Copy link
Collaborator Author

@cchoirat cchoirat added this to the Gather Issues milestone Jun 12, 2019
@schoolAccountMajaG schoolAccountMajaG changed the title June 2019: Data in the package. Selecting Units Data in the package. Selecting Units Jun 14, 2019
@schoolAccountMajaG
Copy link
Collaborator Author

schoolAccountMajaG commented Jun 28, 2019

@cchoirat @lhenneman I would like to make a vignette on how this was prepared for the package. Do you have any R script?

@cchoirat
Copy link
Collaborator

cchoirat commented Jun 28, 2019 via email

@schoolAccountMajaG
Copy link
Collaborator Author

schoolAccountMajaG commented Jun 28, 2019

Also,

Many of the units in the provided datasets do not have stack height data. In these cases, it is suggested in Henneman et al. (2019) to fill with the average stack height of all units.

https://github.com/lhenneman/hyspdisp/blob/master/vignettes/hyads.Rmd#L124-L134

Can we do fill this and get a binary flag variables specifying which ones were filled?

@schoolAccountMajaG
Copy link
Collaborator Author

schoolAccountMajaG commented Jun 28, 2019

More context would help :)

On Fri, Jun 28, 2019 at 1:42 PM Maja @.***> wrote: @cchoirat https://github.com/cchoirat @lhenneman https://github.com/lhenneman I would like to make a vignette on how this was prepared. Do you have any R script? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25?email_source=notifications&email_token=AA73AZIS2SMDDAPA3Z3Y2YLP4X2JRA5CNFSM4HXISIDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYZ3EDQ#issuecomment-506704398>, or mute the thread https://github.com/notifications/unsubscribe-auth/AA73AZKQ4HUQP4VE3KZQSWTP4X2JRANCNFSM4HXISIDA .

I mean. The vignette links to these websites https://ampd.epa.gov/ampd/ https://www.eia.gov/electricity/data/eia860/. What was done after accessing these pages to get the final units data that is in the package?

@lhenneman
Copy link
Owner

lhenneman commented Jun 28, 2019 via email

@cchoirat
Copy link
Collaborator

cchoirat commented Jul 1, 2019 via email

@schoolAccountMajaG
Copy link
Collaborator Author

Yes, but they are using a file that is on a dropbox. How can the user find it if they want to reproduce?

@cchoirat
Copy link
Collaborator

cchoirat commented Jul 1, 2019 via email

@schoolAccountMajaG
Copy link
Collaborator Author

I am sorry to be confusing. I do have the files. I am creating a vignette that explains the whole data manipulation starting from the original data if someone else wanted to access them to replicate the whole process. I think it will be difficult to easily reproduce the data manipulation process unless we share the dropbox file or provide specific instruction on how to download the exact same file from the web.

It is hard to find out which file exactly was downloaded from https://www.epa.gov/air-emissions-inventories/2014-national-emissions-inventory-nei-data. Maybe because I do not have enough background knowledge.

@cchoirat
Copy link
Collaborator

cchoirat commented Jul 1, 2019 via email

@schoolAccountMajaG
Copy link
Collaborator Author

I do not think so.

@lhenneman
Copy link
Owner

lhenneman commented Jul 1, 2019 via email

@lhenneman
Copy link
Owner

lhenneman commented Jul 1, 2019 via email

@schoolAccountMajaG
Copy link
Collaborator Author

"Vignette - Units Data Preparation" shows all the steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants