Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module fails to render if controller calls m.redraw #127

Closed
sdemjanenko opened this issue Jun 6, 2014 · 2 comments
Closed

Module fails to render if controller calls m.redraw #127

sdemjanenko opened this issue Jun 6, 2014 · 2 comments
Labels
Type: Bug For bugs and any other unexpected breakage

Comments

@sdemjanenko
Copy link

Ive been making a data layer similar to Backbone but instead of firing change events it schedules a m.redraw. Unfortunately sometimes it gets called before the controller has returned and this results in the page not rendering at all.

Demo: http://jsfiddle.net/sdemjanenko/64tP9/

@lhorie
Copy link
Member

lhorie commented Jun 9, 2014

I made the redraw call be ignored if the controller is not ready. The normal redrawing mechanism runs when the controller constructor finishes, so this change should simply prevent early null reference exceptions from being thrown. This change is in origin/next and scheduled to be released in v0.1.16

@lhorie lhorie closed this as completed Jun 9, 2014
@lhorie lhorie added the bug label Jun 9, 2014
@sdemjanenko
Copy link
Author

Sweet! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug For bugs and any other unexpected breakage
Projects
None yet
Development

No branches or pull requests

2 participants