Update: Add elem to parent before adding its children #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-claudia
requested changes
Feb 8, 2017
render/tests/test-oninit.js
Outdated
| @@ -187,7 +187,7 @@ o.spec("oninit", function() { | |||
| called = true | |||
|
|
|||
| o(vnode.dom).equals(undefined) | |||
| o(root.childNodes.length).equals(0) | |||
| //o(root.childNodes.length).equals(0) | |||
There was a problem hiding this comment.
Please correct this test instead of just commenting it out.
|
@isiahmeadows Sorry about that as i actually forgot. Fixed now. |
tivac
added
the
Type: Enhancement
|
I'm going to try and carve out some time to investigate the perf (both generally and for this PR). Thank you so much for re-making this change @gyandeeps and I do apologize again that it got lost in the 0.2 to 1.0 shuffle! |
dead-claudia
approved these changes
Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done for 0.2.5 but forgotten for 1.0.0 : #1090 (comment)
Here is the previous PR: #1016
Issue comment: #199 (comment)
This should give enough information.
Theme: Add the element to its parent before you add its children to it. this has perf improvements on IE engines (including Edge).