Add VoxConverse recipe #1142
Merged
Add VoxConverse recipe #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pzelasko ^ quite weird that a random test for a particular python version, totally irrelevant to the changes in the PR, fails |
pzelasko
reviewed
Sep 13, 2023
lhotse/recipes/voxconverse.py
Outdated
| def prepare_voxconverse( | ||
| corpus_dir: Pathlike, | ||
| output_dir: Optional[Pathlike] = None, | ||
| split_test: bool = True, # test part is larger than dev part - split it into dev and test by default |
There was a problem hiding this comment.
Is this a standard thing to do with this dataset? If not, it would be better to return the splits as defined by the creators by default.
flyingleafe
force-pushed
the
voxconverse-recipe
branch
from
93d264e
to
0615651
Compare
|
@pzelasko yes, you're right, probably should not do the resplit by default, changed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From here:
"VoxConverse is an audio-visual diarisation dataset consisting of multispeaker clips of human speech, extracted from YouTube videos.
Updates and additional information about the dataset can be found at our website (https://www.robots.ox.ac.uk/~vgg/data/voxconverse/index.html)."
Note: The default dev/test split is quite weird - namely, the test set is larger than the dev set... Hence, there is an option to use "dev" set as "train", and split "test" set in half into "dev" and "test", which can be disabled in the recipe.