Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download in LibriCSS recipe #1148

Merged
merged 53 commits into from
Sep 14, 2023
Merged

Fix download in LibriCSS recipe #1148

merged 53 commits into from
Sep 14, 2023

Conversation

desh2608
Copy link
Collaborator

No description provided.

@desh2608
add transform attribute for MixedCut
ce0f5c1
@desh2608
add mix_first option in normalize_loudness
ab18682
@desh2608
handle the case when mix is called on MixedCut with existing transforms
e4bca74
@desh2608
add test for mixing with transformed MixedCut
71a9236
@desh2608
enhancements and bug fixes
2e54646
@desh2608
small changes in some cutset methods
db37a75
@desh2608
small fix in error message
7b59ecd
@desh2608
return word alignments from ami recipe
a64727a
@desh2608
add word alignments for ICSI
850ce2c
@desh2608
remove unwanted whitespace
4b39c6f
@desh2608
fix IHM preparation
3c16b90
@desh2608
remove words with zero or negative duration
9921575
@desh2608
ensure word alignments respect segment boundary
dba413f
@desh2608
add save-to-wav option for icsi
12be424
@desh2608
add test for mixing cut with recording
c4b957d
@desh2608
Merge branch 'ami_icsi'
04ca4aa
@desh2608
Merge branch 'cuts'
fef3aa3
@desh2608
Merge branch 'mixed_cut_transform'
0de443e
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse
80619bb
@desh2608
style fix
752be69
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse
5bd483d
@desh2608
Merge branch 'loudness_fix'
68f3ffd
@desh2608
add data prep for voxpopuli
2171d7e
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse
df32e5c
@desh2608
Merge branch 'recipe/voxpopuli'
67c9223
@desh2608
small changes in recipes
c5efbd7
@desh2608
merge upstream
fa00d7c
@desh2608
changes for max segment duration
826dbc2
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse into…
69cba45 
… sups/alignment
@desh2608
remove extra code
e297c13
@desh2608
add alignment scores from CTM
4711576
@desh2608
minor change
128374f
@desh2608
merge trunk
82157d9
@desh2608
made suggested changes
5b51cc4
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse into…
998c245 
… sups/alignment
@desh2608
apply change to multi custom merge func
a347447
@desh2608
remove old code
b9c1704
@desh2608
fix failing tests
22d18d6
@desh2608
add tests for trim to alignments with max segment duration
958a8ec
@desh2608
add tests for merge supervisions
90f2fe0
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse into…
917d4f8 
… sups/alignment
@desh2608
fix merge conflicts
0e36e3f
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse
399834b
@desh2608
fix bug in eval2000
5ecc856
@desh2608
remove storing unnecessary things
293082f
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse into…
71ed2e1 
… fix_manifests
@desh2608
add fix_manifests for all recipes
c4fe1c9
@desh2608
Merge branch 'bug/eval2000'
910f540
@desh2608
Merge branch 'sups/alignment'
b8af9ff
@desh2608
Merge branch 'sups/ctm'
f5b643e
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse
b82e2d0
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse
03470ee
@desh2608
fix unzipping
97d4443
@desh2608 desh2608 mentioned this pull request Sep 14, 2023
Closed
@pzelasko pzelasko added this to the v1.17 milestone Sep 14, 2023
pzelasko
pzelasko approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, how is this exactly different? Anyway, LGTM!

@pzelasko pzelasko merged commit 46cb545 into lhotse-speech:master Sep 14, 2023
10 checks passed
@desh2608
Copy link
Collaborator Author

With the previous, I was getting an error since corpus_zip is a PosixPath type so unzip() does not work on it.

@pzelasko
Copy link
Collaborator

Ohhh, right. I thought it's maybe a method on Path 🤦🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzelasko pzelasko pzelasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@desh2608 @pzelasko