Two new options: CutSet.from_shar(seed="trng") and DynamicCutSampler(quadratic_duration=...)
#1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRNG is useful when dataloading from shar but for any reason the training dataloader has to be recreated between every validation (shar typically depends keeping track of epochs internally to reshuffle the shards, with TRNG it doesn't have to at the cost of lack of exact reproducibility).
exposed quadratic duration in dynamic cut sampler (useful when cutset is sorted by duration, then dynamic cut sampler can act as optimal pseudo-bucketing, and using quadratic_duration can help tune max_duration to an optimal value)