Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpeechSynthesisDataset returns speaker_ids #1206

Merged
merged 11 commits into from
Nov 10, 2023

Conversation

JinZr
Copy link
Contributor

@JinZr JinZr commented Nov 6, 2023

No description provided.

@JinZr JinZr marked this pull request as draft November 6, 2023 08:05
@JinZr JinZr marked this pull request as ready for review November 8, 2023 04:26
@JinZr JinZr marked this pull request as draft November 8, 2023 18:21
lhotse/dataset/speech_synthesis.py Outdated Show resolved Hide resolved
lhotse/dataset/speech_synthesis.py Outdated Show resolved Hide resolved
lhotse/dataset/speech_synthesis.py Outdated Show resolved Hide resolved
@JinZr JinZr marked this pull request as ready for review November 10, 2023 02:38
@JinZr
Copy link
Contributor Author

JinZr commented Nov 10, 2023

we have decided to return the speaker str directly for flexibility, users could make use of the field outside dataloader upon their needs

@pzelasko pzelasko added this to the v1.18 milestone Nov 10, 2023
@pzelasko pzelasko enabled auto-merge (squash) November 10, 2023 02:54
@pzelasko pzelasko merged commit 79821ce into lhotse-speech:master Nov 10, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants