Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save sdm files into a single mdm file to do gss #1221

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

yuekaizhang
Copy link
Contributor

No description provided.

@desh2608
Copy link
Collaborator

I see what you're trying to get at, but I think there may be a more elegant solution which does not need running sox commands during data preparation. You can create a Recording object which has multiple AudioSources, possibly 1 per microphone channel. Then, if you call load_audio with the specified channels, it would load only those channels. This is better in 2 ways:

  1. data is not duplicated
  2. you can load any combination of channels from the recording

As an example, I would suggest looking at the mdm preparation in ICSI: https://github.com/lhotse-speech/lhotse/blob/master/lhotse/recipes/icsi.py

@yuekaizhang
Copy link
Contributor Author

I see what you're trying to get at, but I think there may be a more elegant solution which does not need running sox commands during data preparation. You can create a Recording object which has multiple AudioSources, possibly 1 per microphone channel. Then, if you call load_audio with the specified channels, it would load only those channels. This is better in 2 ways:

  1. data is not duplicated
  2. you can load any combination of channels from the recording

As an example, I would suggest looking at the mdm preparation in ICSI: https://github.com/lhotse-speech/lhotse/blob/master/lhotse/recipes/icsi.py

Done, thanks.

Copy link
Collaborator

@desh2608 desh2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, otherwise LGTM.

lhotse/recipes/icmcasr.py Outdated Show resolved Hide resolved
lhotse/recipes/icmcasr.py Show resolved Hide resolved
@desh2608 desh2608 added this to the v1.18 milestone Nov 28, 2023
@desh2608 desh2608 merged commit 89ca0e6 into lhotse-speech:master Nov 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants