Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lhotse installation without torchaudio for a limited set of features #1231

Merged
merged 12 commits into from
Dec 8, 2023

Conversation

pzelasko
Copy link
Collaborator

@pzelasko pzelasko commented Dec 6, 2023

No description provided.

@pzelasko pzelasko added this to the v1.18 milestone Dec 6, 2023
@pzelasko pzelasko marked this pull request as ready for review December 7, 2023 18:50
@pzelasko
Copy link
Collaborator Author

pzelasko commented Dec 8, 2023

I'm merging - the failed tests are flaky tests of SileroVAD workflow, maybe it's a temporary issue with downloading, if it persists, we'll deal with that separately as it's not affected by this PR.

@pzelasko pzelasko merged commit 78b3a12 into master Dec 8, 2023
8 of 11 checks passed
@pzelasko pzelasko deleted the feature/optional-torchaudio branch December 8, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant