Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent Speech Commands dataset, SLU task #1272

Merged
merged 8 commits into from
Jan 30, 2024

Conversation

HSTEHSTEHSTE
Copy link
Contributor

@pzelasko
Copy link
Collaborator

Thanks!

Please remove the code that’s commented out. Can you also update the table in docs/corpus.rst?

@HSTEHSTEHSTE
Copy link
Contributor Author

Thanks!

Please remove the code that’s commented out. Can you also update the table in docs/corpus.rst?

Done! How do things look now?

pzelasko
pzelasko previously approved these changes Jan 29, 2024
@pzelasko pzelasko added this to the v1.20.0 milestone Jan 29, 2024
@pzelasko pzelasko enabled auto-merge (squash) January 29, 2024 18:35
from pathlib import Path
from typing import Dict, List, NamedTuple, Optional, Tuple, Union

import pandas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move pandas (and ideally also soundfile) into the local import scope so that importing this file does not trigger a hard requirement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed in the latest commit! (Turns out soundfile was not used at all)

auto-merge was automatically disabled January 29, 2024 20:54

Head branch was pushed to by a user without write access

@pzelasko pzelasko enabled auto-merge (squash) January 30, 2024 14:46
@HSTEHSTEHSTE
Copy link
Contributor Author

Is there anything I can do with the two unit tests that failed? The 3.10 failure seems to be the pytest runner having had a random issue. With regards to the codecov/project one, do I need to write a pytest for my recipe?

@pzelasko
Copy link
Collaborator

Don’t worry about these tests — they are flaky and I need to fix them separately. Codecov is just for info and not needed to pass. LGTM!

@pzelasko pzelasko merged commit e3fd608 into lhotse-speech:master Jan 30, 2024
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants