Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioBackend specific save_audio and info, managing missing SoX in torchaudio, Python 3.12 / PyTorch 2.2 support, using libsndfile as preferred audio backend #1288

Merged
merged 11 commits into from
Feb 13, 2024

Prefer LibsndfileBackend as the default lhotse backend (except for so…

9943cdf
Select commit
Loading
Failed to load commit list.
Merged

AudioBackend specific save_audio and info, managing missing SoX in torchaudio, Python 3.12 / PyTorch 2.2 support, using libsndfile as preferred audio backend #1288

Prefer LibsndfileBackend as the default lhotse backend (except for so…
9943cdf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Feb 13, 2024 in 0s

84.93% of diff hit (target 83.75%)

View this Pull Request on Codecov

84.93% of diff hit (target 83.75%)

Annotations

Check warning on line 117 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L117

Added line #L117 was not covered by tests

Check warning on line 237 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L237

Added line #L237 was not covered by tests

Check warning on line 267 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L267

Added line #L267 was not covered by tests

Check warning on line 274 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L274

Added line #L274 was not covered by tests

Check warning on line 344 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L344

Added line #L344 was not covered by tests

Check warning on line 351 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L351

Added line #L351 was not covered by tests

Check warning on line 579 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L579

Added line #L579 was not covered by tests

Check warning on line 683 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L683

Added line #L683 was not covered by tests

Check warning on line 688 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L687-L688

Added lines #L687 - L688 were not covered by tests

Check warning on line 691 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L690-L691

Added lines #L690 - L691 were not covered by tests

Check warning on line 696 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L696

Added line #L696 was not covered by tests

Check warning on line 701 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L701

Added line #L701 was not covered by tests

Check warning on line 723 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L722-L723

Added lines #L722 - L723 were not covered by tests

Check warning on line 735 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L735

Added line #L735 was not covered by tests

Check warning on line 740 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L739-L740

Added lines #L739 - L740 were not covered by tests

Check warning on line 745 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L744-L745

Added lines #L744 - L745 were not covered by tests

Check warning on line 750 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L750

Added line #L750 was not covered by tests

Check warning on line 1490 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L1490

Added line #L1490 was not covered by tests

Check warning on line 1493 in lhotse/audio/backend.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/backend.py#L1493

Added line #L1493 was not covered by tests

Check warning on line 286 in lhotse/audio/recording.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

lhotse/audio/recording.py#L286

Added line #L286 was not covered by tests