Fix randomness in CutMix transform #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
osadj
reviewed
Apr 3, 2024
test/dataset/test_cut_transforms.py
Outdated
| noise_cuts = DummyManifest(CutSet, begin_id=100, end_id=102) | ||
|
|
||
| # called twice on the same input, expecting different results | ||
| tfnm = CutMix(noise_cuts, snr=None, p=1.0, seed=0, preserve_id=True) |
osadj
reviewed
Apr 3, 2024
| tfnm = CutMix(noise_cuts, snr=None, p=1.0, seed=0, preserve_id=True) | ||
| out1 = tfnm(speech_cuts) | ||
| out2 = tfnm(speech_cuts) | ||
| assert list(out1) != list(out2) |
There was a problem hiding this comment.
Thanks for adding this test. I ran this using v1.17 which is stateless, but I still got different outputs (i.e., out1 and out2 are different). This is counterintuitive because CutMix passes the same seed in every __call__ to cuts.mix. can you please help me understand this?
There was a problem hiding this comment.
It used CutSet.sample which was not seeded and used the global RNG. If I start any new library from scratch I’ll keep it in mind to have a methodical approach to RNG handling from the beginning.
There was a problem hiding this comment.
ah, you're right. I forgot about that. Thanks again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.