Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In CommonVoice corpus, use .tsv headers to parse and not column index #1328

Merged
merged 7 commits into from
Apr 29, 2024

Conversation

daniel-dona
Copy link
Contributor

Minor parsing change, fix for #1325

@pzelasko
Copy link
Collaborator

Thank you, this looks good, LMK when it's ready to merge.

@@ -207,9 +208,16 @@ def _prepare_part(
futures = []
recordings = []
supervisions = []

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unnecessary whitespace

audio_infos = iter(f.readlines())
# Create a dict for each row
# Ex: {'client_id': '0da3ad6381619ef478d86896731ccbf88c6209354a892a5c69b8259a67919b4755b14427ef80b197c4c3886e906849dd6af792d3e631eb9ac1cbc110019f5201', 'path': 'common_voice_de_19058316.mp3', 'sentence_id': '9416f9e6c0524877a0437e143c62c8502160b0bf6246126c94894deca0fcad28', 'sentence': 'Alle Fluchtwege sind abgeschnitten.', 'sentence_domain': '', 'up_votes': '2', 'down_votes': '0', 'age': 'teens', 'gender': 'male_masculine', 'accents': 'Deutschland Deutsch', 'variant': '', 'locale': 'de', 'segment': ''}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

@daniel-dona daniel-dona marked this pull request as ready for review April 27, 2024 21:48
@daniel-dona
Copy link
Contributor Author

Thank you, this looks good, LMK when it's ready to merge.

I think it ready

@pzelasko pzelasko added this to the v1.23.0 milestone Apr 29, 2024
@pzelasko
Copy link
Collaborator

Thanks!

@pzelasko pzelasko merged commit b2dce78 into lhotse-speech:master Apr 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants