Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for ami recipe #85

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Conversation

jimbozhang
Copy link
Contributor

Avoid generating extremely long segments. #83

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   93.16%   93.16%           
=======================================
  Files          37       37           
  Lines        2838     2838           
=======================================
  Hits         2644     2644           
  Misses        194      194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0059c2...a5f400f. Read the comment docs.

@pzelasko
Copy link
Collaborator

How does this affect the output of prepare_ami? Can you put a comment in the code explaining the changes?

@jimbozhang
Copy link
Contributor Author

How does this affect the output of prepare_ami? Can you put a comment in the code explaining the changes?

I made a new commit, in which the codes are cleaned and some comments are added. There are some bad cases in AMI's annotation file, and this PR deals with those bad cases. @pzelasko

@pzelasko
Copy link
Collaborator

Thanks!

@pzelasko pzelasko merged commit 56ecbae into lhotse-speech:master Sep 29, 2020
@jimbozhang jimbozhang deleted the jzhang.ami branch September 29, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants