Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add running gofmt to the PR template #259

Merged
merged 2 commits into from Mar 14, 2019
Merged

Add running gofmt to the PR template #259

merged 2 commits into from Mar 14, 2019

Conversation

vadymeng0
Copy link

Description

Just a minor change - I propose to add running gofmt to the PR template checklist because committers (at least personally myself) constantly forgetting to do that.

Type of change

  • New feature (non-breaking change which adds functionality)

@vadymeng0 vadymeng0 self-assigned this Mar 13, 2019
@vadymeng0 vadymeng0 added the ci label Mar 13, 2019
@vadymeng0 vadymeng0 added this to In progress in Aminal v1.0 via automation Mar 13, 2019
@maxhora maxhora changed the base branch from master to develop March 14, 2019 09:22
@maxhora maxhora merged commit 4f308bd into develop Mar 14, 2019
Aminal v1.0 automation moved this from In progress to Done Mar 14, 2019
@liamg liamg deleted the add_gofmt_to_checklist branch July 30, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhora maxhora maxhora approved these changes

@liamg liamg Awaiting requested review from liamg

Assignees

@vadymeng0 vadymeng0

Labels
ci
Projects
No open projects
Aminal v1.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vadymeng0 @maxhora @liamg