Remove deployment target specifications for non-macOS platforms #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use the xcstrings-tool repo (this one) directly so that you compile the CLI from source, it had previously been restricted to iOS/tvOS 16 and watchOS 9 despite the plugin generating code that was compatible with earlier OS versions.
It turns out that because the CLI, and even the build tool plugin are executed on the host build machine, we didn't actually need to specify deployment targets for other platforms, and by doing so, it was needlessly restricting us.
This PR removes those definitions so that if you prefer to use the plugin from source, you can. As long as you use macOS 13 or later.