Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification of compact signatures. #19

Merged
merged 3 commits into from
Jun 23, 2013
Merged

Add verification of compact signatures. #19

merged 3 commits into from
Jun 23, 2013

Conversation

sowbug
Copy link
Contributor

@sowbug sowbug commented Jun 23, 2013

Per discussion in #18.

@sowbug
Copy link
Contributor Author

sowbug commented Jun 23, 2013

I forgot to update the error message at the top of openssl.rb. "Skipping FFI needed for OpenSSL_EC.regenerate_key" should either be generalized or else list every public method this module implements.

@lian
Copy link
Owner

lian commented Jun 23, 2013

yea good note. i'm currently merging and fixing the memory leaks in that new method. going to push soon.

@lian lian merged commit 5157030 into lian:master Jun 23, 2013
@lian
Copy link
Owner

lian commented Jun 23, 2013

Thanks for your contribution! adding signmessage would be nice too :)

@mhanne
Copy link
Contributor

mhanne commented Jun 23, 2013

Nice! AFAIK, an FFI::MemoryPointer frees itself, unless autorelease = false is set.
That it uses a CDataStream is a bit unfortunate. FWIW, I've quickly tried changing the #wrap_message_in_magic to something like this:
out = "\x18Bitcoin Signed Message:\n"
message.split("").each_slice(255) {|c| out << c.size.chr; out << c.join }
out
... but that doesn't seem to be how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants