-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement some design suggestions from #11 #54
Conversation
* Added TailwindCSS * Added Leaflet * Added basic settings menu * Added dark mode to UI * Add ability to toggle instruments
This commit adds two things: New vfrmap design Based on suggestions from lian#21, this commit adds a different design with a small settings menu to toggle a dark mode and instrument displays. I imported two external sources for this, Tailwind and Alpine.JS. They are currently not part of the bindata. go-bindata generation There was not really a hint on how to generate all the bindata, so I added a Makefile to the vfrmap project and the html subdirectory, so when running `make generate`, the dependencies (leafletjs, the rotatedMarker plugin) will be downloaded and prepared. Afterwards, `go generate` will be run. The download of the vendor files can be triggered on its own from the html/Makefile using `make vendor`.
@lian would you mind adding a |
* Renamed path to `/static` * Renamed module from "leafletjs" to "dependencies" * Added in Tailwind and AlpineJS to static * Updated Makefile
…pendencies Add Tailwind and Alpine to static assets
@lian I embedded the two new dependencies (tailwind and alpinejs) into the bindata now, I renamed some stuff while doing that (mainly leafletjs into "dependencies") so this PR increased in size a bit. If you just want to see the changes from embedding the new dependencies, you can check the diff here: Rukenshia#1 Let me know if there's anything you want changed about this PR before merging :) |
great work so far :) would be awesome to toggle each instrument value aswell, some may want airspeed as true or indicated, etc. another feature request was showing remaining fuel, so some might what to view this and some don't. edit: will def find time this coming week to merge your PRs and release a new version. |
Can definitely work on that and implement more settings to toggle certain instruments. |
@lian fixed the |
Hey @lian, do you think you'll have time to get around to merging and releasing this anytime soon? :) |
This PR adds two things:
New vfrmap design
Based on suggestions from #21, this PR adds a different design with
a small settings menu to toggle a dark mode and instrument displays.
I imported two external sources for this, Tailwind and Alpine.JS. They
are currently not part of the bindata. If you want me to change that, I'm
happy to provide another PR.
You can find a screenshot of it in #21.
go-bindata generation helpers
There was not really a hint on how to generate all the bindata, so I
added a Makefile to the vfrmap project and the html subdirectory, so
when running
make generate
, the dependencies (leafletjs, therotatedMarker plugin) will be downloaded and prepared. Afterwards,
go generate
will be run.The download of the vendor files can be triggered on its own from the
html/Makefile using
make vendor
.