Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual Save Broken #235

Closed
PinkPenguin418 opened this issue Feb 18, 2024 · 4 comments
Closed

Manual Save Broken #235

PinkPenguin418 opened this issue Feb 18, 2024 · 4 comments
Assignees
@liana-p
Labels
bug Something isn't working

Comments

@PinkPenguin418
Copy link
Contributor

Describe the bug
When doing a manual save the game stops working. We receive the following error in the debugger "Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'layers')". Identified the potential culprit to be the variable "save.screen.layers[0]" in the "save-slot-ui.vue" file on line 77 and 78. It should likely be "save.screens.layers[0]"

To Reproduce
Steps to reproduce the behavior:

  1. In code have a line that uses save "Manual Save 1"
  2. Run that line.

Expected behavior
I'd expect the manual save dialog to appear.

Screenshots
No screenshots available

Browser
Running this on latest version of Chrome.
@PinkPenguin418 PinkPenguin418 added the bug Something isn't working label Feb 18, 2024
@PinkPenguin418
Copy link
Contributor Author

Ok, explored a bit more (tried to fix it myself). Appears that sometimes save.screens.layers[0] is need other times its save.screen.layers[0].

@PinkPenguin418
Copy link
Contributor Author

figured it out, it was old saves that were showing up as save.screen.layers[0] instead of save.screens.layers[0]. I removed them and now only see save.screens.layers[0]. I'll see if I can create a PR.

PinkPenguin418 added a commit to PinkPenguin418/narrat-engine that referenced this issue Feb 19, 2024
@PinkPenguin418
fix: liana-p#235
a984475
@PinkPenguin418 PinkPenguin418 mentioned this issue Feb 19, 2024
Merged
3 tasks
liana-p pushed a commit that referenced this issue Feb 19, 2024
@PinkPenguin418
fix: error when doing manual saves #235 (#236)
7208dc0
@liana-p
Copy link
Owner

liana-p commented Feb 19, 2024

fixed by #236

@liana-p liana-p closed this as completed Feb 19, 2024
@liana-p
Copy link
Owner

liana-p commented Feb 19, 2024

I just made a release with the change, should be 3.9.8

liana-p pushed a commit that referenced this issue May 9, 2024
@PinkPenguin418
fix: loading save data reference fix #255 (#272)
d2cf05f 
* fix: #235

* fix(#255): VM object referenced from save
liana-p pushed a commit that referenced this issue May 15, 2024
@PinkPenguin418
fix: custom stores saving issue #274 (#275)
dcb1924 
* fix: #235

* fix(#255): VM object referenced from save

* fix(#274): Add logic to store management to fix custom store save issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liana-p liana-p

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liana-p @PinkPenguin418