fix tuple int comparison error in version check #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this plugin!
My builds started failing with the latest release. Here's an example.
tl;dr: I'm getting errors on the new version info comparison wrapped around the locale setting, because the commit to resolve #50 introduced the expression
sys.version_info[0] < (3, 11), which produces3 < (3, 11)and then aTypeError. This code path is only triggered if_localeis not set in the call, so it may have been missed in testing.The change in this PR should give the desired behavior. We check the tuple
sys.version_info[:2]against(3, 11)instead. FWICT, this retains compatibility with Python <= 3.0 (docs here). If Python >= 3.1 is okay, then(sys.version_info.major, sys.version_info.minor)in place of the direct indexing would be more clear.Note that this commit also adds a newline at the end of file -- that's the default behavior of most editors. You can edit to remove it if you want.