Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragment.scopeLife默认销毁生命周期错误 #80

Closed
lexdev7 opened this issue Apr 28, 2022 · 7 comments
Closed

Fragment.scopeLife默认销毁生命周期错误 #80

lexdev7 opened this issue Apr 28, 2022 · 7 comments
Labels
Bug Something isn't working

Comments

@lexdev7
Copy link

lexdev7 commented Apr 28, 2022

053b434fb3bc2b5e36599a39a77d950
@liangjingkanji
Copy link
Owner

我感觉是写错了, 被你抓到了

既然是你抓到的, 如果你有想法的话可以发起pr

@lexdev7
Copy link
Author

lexdev7 commented Apr 28, 2022

哈哈，我来试试

@liangjingkanji
Copy link
Owner

提醒下提交使用自己GitHub账号邮箱自己的头像才会出现在Contributors

@liangjingkanji liangjingkanji added the 文档错误 Improvements or additions to documentation label Apr 28, 2022
@lexdev7
Copy link
Author

lexdev7 commented Apr 28, 2022

我觉得应该改为Lifecycle.Event.ON_DESTROY，这样是否合理

@liangjingkanji
Copy link
Owner

liangjingkanji commented Apr 28, 2022 •
edited

已修复, 默认替换为ON_DESTROY

@liangjingkanji liangjingkanji added Bug Something isn't working and removed 文档错误 Improvements or additions to documentation labels Apr 28, 2022
@liangjingkanji liangjingkanji changed the title 这里是注释写错了嘛 Fragment.scopeLife默认销毁生命周期错误 Apr 28, 2022
@lexdev7
Copy link
Author

lexdev7 commented Apr 28, 2022

好的，谢东哥

@liangjingkanji
Copy link
Owner

你这刚好提醒到我了, 你现在使用最新版本吧

liangjingkanji added a commit that referenced this issue Apr 28, 2022
@liangjingkanji
Fixed #80
620436c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liangjingkanji @lexdev7