Merge pull request ChatGPTNextWeb#2028 from Yidadaa/bugfix-0618

fix: ChatGPTNextWeb#1771 should not lose chat context when sumindex > n - count
liaol · Jun 17, 2023 · 1c7f3e6 · 1c7f3e6
2 parents 0a2cccf + db63a5a
commit 1c7f3e6
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/app/store/chat.ts b/app/store/chat.ts
@@ -370,28 +370,30 @@ export const useChatStore = create<ChatStore>()(
           context.push(memoryPrompt);
         }
 
-        // get short term and unmemoried long term memory
+        // get short term and unmemorized long term memory
         const shortTermMemoryMessageIndex = Math.max(
           0,
           n - modelConfig.historyMessageCount,
         );
         const longTermMemoryMessageIndex = session.lastSummarizeIndex;
-        const mostRecentIndex = Math.max(
+
+        // try to concat history messages
+        const memoryStartIndex = Math.min(
           shortTermMemoryMessageIndex,
           longTermMemoryMessageIndex,
         );
-        const threshold = modelConfig.compressMessageLengthThreshold * 2;
+        const threshold = modelConfig.max_tokens;
 
         // get recent messages as many as possible
         const reversedRecentMessages = [];
         for (
           let i = n - 1, count = 0;
-          i >= mostRecentIndex && count < threshold;
+          i >= memoryStartIndex && count < threshold;
           i -= 1
         ) {
           const msg = messages[i];
           if (!msg || msg.isError) continue;
-          count += msg.content.length;
+          count += estimateTokenLength(msg.content);
           reversedRecentMessages.push(msg);
         }