Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set default options correctly for useFactory #129

Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix: set default options correctly for useFactory #129

merged 1 commit into from
Oct 13, 2021

Conversation

liaoliaots
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • set default options correctly for useFactory
  • add missing redis status

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@liaoliaots liaoliaots merged commit 1081ca5 into main Oct 13, 2021
@liaoliaots liaoliaots deleted the fix-default-options branch October 13, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@liaoliaots