Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to v6 #189

Merged
merged 8 commits into from Feb 19, 2022
Merged

feat!: upgrade to v6 #189

merged 8 commits into from Feb 19, 2022

Conversation

liaoliaots
Copy link
Owner

@liaoliaots liaoliaots commented Feb 19, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: apis, messages, comments, dependencies, refactor

What is the current behavior?

Issue Number: #175
redis and cluster module both are global module by default and no option to configure it

What is the new behavior?

  • add isGlobal option as the second param and set its default value to true
// RedisModule
static forRoot(options: RedisModuleOptions = {}, isGlobal = true): DynamicModule;
static forRootAsync(options: RedisModuleAsyncOptions, isGlobal = true): DynamicModule;
// ClusterModule
static forRoot(options: ClusterModuleOptions, isGlobal = true): DynamicModule;
static forRootAsync(options: ClusterModuleAsyncOptions, isGlobal = true): DynamicModule;
  • use correct method instead of instanceof to prevent some bugs in realms env
  • change default namespace from Symbol('default') to 'default'
  • remove status exports
  • extract common utils
  • update messages
  • update comments
  • update dependencies
  • update unit tests

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@liaoliaots liaoliaots merged commit 79a6b8b into main Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant