Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: solve some issues for health checks #200

Merged
merged 3 commits into from
Mar 10, 2022
Merged

refactor: solve some issues for health checks #200

merged 3 commits into from
Mar 10, 2022

Conversation

liaoliaots
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • fix wrong ignore file patterns in .prettierignore
  • update code comments
  • update messages
  • fix falsy 0 when using memoryThreshold
  • remove redis-errors

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

- update code comments
- update messages
- refactor checkHealth
- update version
@liaoliaots liaoliaots merged commit e5906e6 into main Mar 10, 2022
@liaoliaots liaoliaots deleted the v7 branch March 10, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant