Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix email validating regex in devops-api #411

Closed
jburns24 opened this issue Nov 30, 2023 · 0 comments · Fixed by #412
Closed

Fix email validating regex in devops-api #411

jburns24 opened this issue Nov 30, 2023 · 0 comments · Fixed by #412
Assignees
@cfculler

Comments

@jburns24
Copy link
Collaborator

https://github.com/liatrio/devops-bootcamp/blob/master/examples/ch7/devops-api/main.go#L18-L21

this regex is too limiting and valid emails like carson.culler@liatrio.com will be rejected. Carson lost a good day and a half to this thinking the issue was in his provider code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfculler cfculler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expanded email regex and repinned devops-resources to working version liatrio/devops-bootcamp
2 participants
@jburns24 @cfculler