Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic http respond to respond to Azure pings #108

Merged
merged 1 commit into from
Jul 3, 2021
Merged

Conversation

Pactionly
Copy link
Contributor

Azure App Service requires containers to respond to http pings to be consider healthy. Configuring Gratibot to use socket mode disabled its ability to respond to these pings and caused the service to be flagged as unhealthy.

Ideally we'd configure Gratibot with custom routes as part of the receiver package in Bolt, however, the SocketModeReceiver doesn't currently support custom routes. See: slackapi/bolt-js#834

Until support is added (Milestone 3.5.0), this PR adds a basic express response to satisfy Azure's requirements.

@Pactionly Pactionly requested a review from gesparza3 July 3, 2021 16:44
@github-actions
Copy link

github-actions bot commented Jul 3, 2021

Terraform Nonprod Plan success

Show Plan
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # azurerm_app_service.gratibot_app_service will be updated in-place
  ~ resource "azurerm_app_service" "gratibot_app_service" {
      ~ app_settings                      = {
          - "DOCKER_REGISTRY_SERVER_URL"  = "https://index.docker.io/v1" -> null
            # (5 unchanged elements hidden)
        }
        id                                = "/subscriptions/761bf739-12c3-43cb-bec9-d87c1d7fa459/resourceGroups/gratibot-azure-data/providers/Microsoft.Web/sites/gratibot-nonprod-service"
        name                              = "gratibot-nonprod-service"
        tags                              = {}
        # (14 unchanged attributes hidden)




      ~ site_config {
          ~ linux_fx_version            = "DOCKER|liatrioalicej/gratibot:3.0.0" -> "DOCKER|ghcr.io/liatrio/gratibot:0830aa4"
            # (17 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@Pactionly Pactionly merged commit c62b0f4 into main Jul 3, 2021
@Pactionly Pactionly deleted the respond-to-pings branch July 3, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant