Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional feature additions #62

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

mitchell-liatrio
Copy link
Contributor

@mitchell-liatrio mitchell-liatrio commented May 8, 2024

  1. add workflow link to comment (Link in plan comment to workflow  #14)
  2. Add header and footer to the comment
  3. quite mode. dont comment if there are no changes (Add a quiet mode where the action doesn't leave a comment if there are no planned changes #11)

This pull request introduces multiple changes to the GitHub Actions workflows and the Terraform Change PR Commenter. The most significant changes include updating the node-version and other parameters in the .github/workflows/action-test.yml and .github/workflows/release.yml files, renaming the Terraform Change PR Commenter and adding new input parameters in the action.yml file, and enhancing the index.js script with new features such as quiet mode and including a link to the workflow in the comment.

Updates to GitHub Actions workflows:

  • .github/workflows/action-test.yml: The node-version and other parameters have been updated to use double quotes instead of single quotes. New parameters such as comment-header, comment-footer, include-workflow-link, and quiet have also been added. [1] [2]
  • .github/workflows/release.yml: The node-version parameter has been updated to use double quotes, and a new release trigger has been added.

Changes to the Terraform Change PR Commenter:

  • action.yml: The name of the Terraform Change PR Commenter has been updated to version 2, and new input parameters such as comment-header, comment-footer, include-workflow-link, and quiet have been added. [1] [2]

Enhancements to the index.js script:

  • index.js: New features have been added such as quiet mode and including a link to the workflow in the comment. The script has also been enhanced to better handle changes in the Terraform plan and improve error handling. [1] [2] [3] [4] [5]

Copy link

github-actions bot commented May 8, 2024

Terraform Plan Changes

Terraform Plan: 11 to be created, 0 to be deleted, 0 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_interface.calvin-nic
+ azurerm_network_interface_security_group_association.calvin-sg-nic
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh

Terraform Plan Changes

Terraform Plan: 9 to be created, 1 to be deleted, 1 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh

Resources to delete

- azurerm_network_interface.calvin-nic

Resources to update

! azurerm_network_interface_security_group_association.calvin-sg-nic

Terraform Plan Changes

Terraform Plan: 1 to be created, 0 to be deleted, 1 to be updated, 1 to be replaced, 35 unchanged.

Resources to create

+ module.aks_lz.module.key_vault.azurerm_private_endpoint.key_vault

Resources to update

! module.aks_lz.module.key_vault.azurerm_key_vault.key_vault

Resources to replace

- module.aks_lz.azurerm_virtual_hub_connection.aks_vnet_hub_connection[0]
+ module.aks_lz.azurerm_virtual_hub_connection.aks_vnet_hub_connection[0]

Copy link

github-actions bot commented May 8, 2024

BIG HEADER

Terraform Plan: 11 to be created, 0 to be deleted, 0 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_interface.calvin-nic
+ azurerm_network_interface_security_group_association.calvin-sg-nic
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh
BIG FOOTER

Workflow: Action Tester Workflow

Copy link

github-actions bot commented May 8, 2024

There were no changes done to the infrastructure.

@mitchell-liatrio
Copy link
Contributor Author

@someshkoli I opened this from another PR since it's not coming from a fork which was causing problems with some of the workflows

@mitchell-liatrio mitchell-liatrio merged commit 1465fa2 into main May 8, 2024
4 checks passed
@mitchell-liatrio mitchell-liatrio deleted the someshkoli-features branch May 8, 2024 17:22
github-actions bot pushed a commit that referenced this pull request May 8, 2024
# [1.5.0](v1.4.5...v1.5.0) (2024-05-08)

### Features

* additional feature additions ([#62](#62)) ([1465fa2](1465fa2))
* multiple feature addition [#58](#58)  ([#60](#60)) ([01f0321](01f0321))

### Reverts

* Revert " feat: multiple feature addition #58  (#60)" (#63) ([ab68bb6](ab68bb6)), closes [#58](#58) [#60](#60) [#63](#63)
Copy link

github-actions bot commented May 8, 2024

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants