Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Context Support #506

Closed
freeformz opened this issue Sep 21, 2016 · 8 comments
Closed

Add Context Support #506

freeformz opened this issue Sep 21, 2016 · 8 comments

Comments

@freeformz
Copy link

This is to track support for this https://go-review.googlesource.com/c/29381/

@freeformz
Copy link
Author

golang/go#15123 is closed and this has landed in master as golang/go@e13df02

@freeformz
Copy link
Author

See also: https://go-review.googlesource.com/#/c/30166/

@johto @uhoh-itsmaciek You may want to take a look at that CL if interested.

@itsjamie
Copy link

itsjamie commented Nov 7, 2016

#531 is related

@maddyblue
Copy link
Collaborator

I'm actively working on this but don't have a full PR ready yet. If someone else has interest I'm happy to coordinate.

@itsjamie
Copy link

itsjamie commented Nov 7, 2016

@mjibson I was planning on working on one of the tickets I've linked to through #531, it looks like a lot of it runs through the new context-based API. I'd be happy to work with you if you've got something you can split off for me to work on.

@maddyblue
Copy link
Collaborator

I've just got this working so I'll send a PR soon. Need to write some tests first.

@nathany
Copy link

nathany commented Feb 3, 2017

With #535 merged, is this issue closed?

@tamird
Copy link
Collaborator

tamird commented Feb 3, 2017

Yep!

@tamird tamird closed this as completed Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants