implement driver.Pinger interface #737
Conversation
|
Unfortunately the db.Conn method was not exported in go1.8, thus those tests failed. Will work around this tomorrow. |
|
Struggled with the same problem. Hope this gets merged soon. |
|
ping @mjibson |
|
Some handling of the Ping interface would be good to have in the driver to prevent further confusion. Please consider this to be merged in the next release for v1.1.0 of lib/pq. Closing #675 in favor of this as it is a superset of what I had written, with the test as @ghouscht mentioned and @mjibson requested in the original review. |
conn_go18.go
Outdated
| if err != nil { | ||
| return driver.ErrBadConn // https://golang.org/pkg/database/sql/driver/#Pinger | ||
| } | ||
| defer rows.Close() |
There was a problem hiding this comment.
no need for the defer. just close it.
There was a problem hiding this comment.
Sure, changed that and squashed all the commits together. So this can hopefully be merged soon.
|
When can this be merged? Looks like a good solution for the Pinger implementation and would close #533 which is a limitation. |
|
cc @mjibson This PR LGTM |
This PR implements the driver.Pinger interface. I had some trouble in an internal project because I relayed on database/sql's Ping Method to check the DB connection. Unfortunately this interface is currently not implemented (nor documented -> resulting in a inaccurate default behaviour) by lib/pq and I lost quite a bit of time finding out why.
Credits to @itsjamie who created the original PR #675 (code is mostly copy/paste) except for the tests (anyway idea for the test also came from @itsjamie).
I hope to get some attention with this PR so this (or PR #675) can be merged to master.