-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hackathon TODO list #55
Comments
We agreed to deprecate FortranArray by adding warnings whenever accessed |
How will atoms/neighbours be indexed in quippy then? Still one-based? It used to be quite convenient to loop over them with frange(at.n). |
For ASE-style usage such as For quippy-style usage such as |
And we will be able to turn off the warning system if you want to write quippy style |
Sounds good. The reason I'm asking because I very often use the neighbour() function which expects the arguments as one-based. I'd use ase if the same functionality existed but last time I looked I couldn't find it. |
Is anyone working on the scaling factors for the Sum potential? |
You can continue to write quippy code, and it will be fine |
You can't implement scaling in a generic way, so let's just issue the warning. go ahead @albapa and do it if you like |
we've just been talking about neighbour lists - ASE builtin is |
regarding the scaling factors - would that be energy and r-scale both? |
See Gabor's comments under issue #51 for the scaling factors - I think the current task is only to add warnings. |
If there are no objections I'm going to close this issue - I think everything is recorded on separate issues. I'll make a PR for Hackathon branch now; hackathon-f90wrap will stay around for a while longer as we continue to work on it. |
|
QUIP Hackathon TODO
This issue is to collect tasks for next week's QUIP Hackathon. Please edit the list below, adding links to other issues where appropriate. We can then add tags to assign tasks to people who would like to work on them.
Code Maintenance
FortranArray
(see e.g. quippy documentation and cleanup #53)Atoms
functions) and the one-based indexing in QUIPAtoms
functionsquippy
command line tools such asconvert.py
to use ASE file formats (see quippy reader should fallback on ase.io.read() for unknown formats #10) @fcmocanuDocumentation
quip-reference-manual.pdf
? #52)New features
The text was updated successfully, but these errors were encountered: