Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

definition of strain #12

Open
gabor1 opened this issue Jul 20, 2018 · 2 comments
Open

definition of strain #12

gabor1 opened this issue Jul 20, 2018 · 2 comments

Comments

@gabor1
Copy link

gabor1 commented Jul 20, 2018

hi Guys!

Vikram and I were reviewing the code in get_delta_plus_epsilon(), because we wanted to understand exactly what was being calculated. Here are some suggestions:

  1. you compute the deformation matrix, which is indeed delta+epsilon, as suggested by the name of the function, but then the name of the variable into which it is accumulated is just called epsilon, which is confusing.

  2. The deformation matrix that is thus computed is not symmetric, so can include rotations. we suggest to take those out, using M.T*M

  3. To actually get a strain, one has to subtract the identity, so we suggest that is done, so the final thing returned should be 0.5 (M.TM - I) where M is the thing accumulated in get_delta_plus_epsilon()

@pastewka
Copy link
Collaborator

pastewka commented Jul 21, 2018 via email

@gabor1
Copy link
Author

gabor1 commented Jul 21, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants