BUILD: Switch to Meson for building #117

pastewka · 2022-11-29T15:11:01Z

Switched the build system from setuptools to Meson. Added pyproject.toml. Removed setup.py.

…ndows-wheels

prs513rosewood · 2022-12-13T14:16:33Z

Seems that the tests are failing because pip still installs _matscipy.so as a standalone package despite my changes. I've had that happen on my machine and fixed it with a newer pip version.

With "-dirty" as version suffix, pip fails the wheels installation with the following errors: - pip 22.3.1 `WARNING: Built wheel for matscipy is invalid: matscipy-0.8.0.rc1.dev89+gb96ca41-dirty-cp310-cp310-linux_x86_64.whl is not a valid wheel filename.` - pip 22.2.2 `WARNING: Built wheel for matscipy is invalid: matscipy has an invalid wheel, matscipy has an invalid wheel, multiple .dist-info directories found: matscipy-0.8.0.rc1.dev90+g0ebd368.dist-info, matscipy-0.8.0.rc1.dev90+g0ebd368-dirty.dist-info` The wheels naming convention allows for a numeric build tag, so "-dirty" does not work. With ".dirty" it becomes part of the version spec.

ImportError is too generic for trying to import ._matscipy, DLL problems can be overlooked.

prs513rosewood · 2022-12-20T14:34:49Z

I've added a simple check to cibuildwheel that makes sure both the package and the compiled extension can be imported. Looks like it's working for every wheel, and I've separately tested the windows wheels on bare metal. If the macos wheels work the PR can probably be merged.

jameskermode · 2022-12-20T14:49:24Z

thank you @prs513rosewood! Last time I checked there was still an issue with the Mac arm64 wheel, I'll test that again now.

jameskermode · 2022-12-20T16:14:36Z

MacOS X arm64 wheel still doesn't install. The .so file inside is arm64, but both the metadata filename say its x86_64. It would also be nice to have arm64 wheels for other Python versions (3.8, 3.9, 3.10, 3.11 to be consistent with the other platforms). However, to make progress shall we decouple things by removing arm64 support from this PR and working on it in a new one, so as not to hold up releasing Linux and Windows wheels to PyPI?

jameskermode · 2022-12-20T16:17:15Z

I've added a simple check to cibuildwheel that makes sure both the package and the compiled extension can be imported. Looks like it's working for every wheel, and I've separately tested the windows wheels on bare metal. If the macos wheels work the PR can probably be merged.

Thanks, good idea - but unfortunately this won't work for arm64 since they are cross-compiled on x86_64 (until GitHub get Apple Silicon runners which I did hear about somewhere as a future) plan. Another reason to work on arm64 in a new PR.

jameskermode · 2022-12-20T16:21:41Z

I created #122 which is a copy of this PR and then removed the arm64 wheels from this one. If all CI Actions pass then this one should be OK to merge.

prs513rosewood · 2022-12-20T17:33:50Z

The cibuildwheel test actually runs only for wheels built by cibuildwheel. I'm ok with pushing the arm builds to a separate PR, but before merging I'll make a quick change: Numpy recommands using oldest-supported-numpy as a build requirement instead of regular Numpy, to avoid backwards incompatibility (i.e. if the build system pulls a version of numpy at compile time more recent than the one available at runtime).

jameskermode · 2022-12-20T17:35:28Z

I agree with using oldest-supported-numpy - we also do it with f90wrap and quippy wheels (and I thought I'd done it here too but must have got lost in all the edits in this branch)

See https://numpy.org/devdocs/user/troubleshooting-importerror.html#c-api-incompatibility

jameskermode and others added 29 commits November 23, 2022 10:57

Update build-wheels.yml

903e896

Update build-wheels.yml

fe65d70

Update build-wheels.yml

8d8c9e7

only check for compiler.compiler[0] when not on Windows

607969a

include <cmath> for MS C++

4c9c50d

remove compiler env settings

1928483

restrict to MS C++

daffc0b

Update build-wheels.yml

20dd60a

compile C sources as C++

c648672

Merge branch 'windows-wheels' of github.com:libAtoms/matscipy into wi…

2406d1b

…ndows-wheels

fix dest of move

8352edf

revert some C to C++ conversions

aa423b2

add explicit pointer conversions

e097336

Standards compliant variable length array for MSVC++

908cd86

WIP: Meson build files

1270f85

MAINT: Version discovery in Meson

95ab67e

MAINT: Proper version import

5dd246e

CI: Meson-compatible build

67cc5f9

MAINT: Need to specify numpy include directory

b3456ca

CI: requirements.txt no longer exists

66fbe53

MAINT: Added missing source files

eeb8524

MAINT: Added missing source files and directories

96cf885

BUILD: Fixed wrong path to fracture_mechanics module

a35f791

DOC: Updated CONTRIBUTING.md

4d0cc23

MAINT: Deprecated import

2995a48

BUILD: Added lammpsdata.py

6520df6

DOC: Updated ChangeLog.md

ee6c4f5

BUILD: Removed superfluous information from setup.cfg

aa2efd3

BUILD: Some version mangling madness

6d85f14

pastewka changed the title ~~MAINT: Switch to Meson for building~~ BUILD: Switch to Meson for building Nov 29, 2022

added _matscipy as submodule

61f46f6

prs513rosewood added 11 commits December 13, 2022 15:42

top-level _matscipy workaround

b96ca41

added headers and docstring to ffi.py

0ebd368

narrow catch to ModuleNotFoundError

ae8908c

ImportError is too generic for trying to import ._matscipy, DLL problems can be overlooked.

statically linking gcc components

e791808

numpy.float is deprecated

7202625

testing extension import after wheel build

9272fa3

corrected test command to use python 3

360c8c1

changed quotes in CIBW test

9cf26b9

testing ffi import in standalone file

219c991

using cibw virtualenv python command

e4c03c9

This was linked to issues Dec 20, 2022

Fail to install matscipy on Windows system #102

Closed

Build Wheels #106

Closed

remove arm64 wheels from this PR

1bb1d97

jameskermode mentioned this pull request Dec 20, 2022

arm64 wheels #122

Merged

jameskermode approved these changes Dec 20, 2022

View reviewed changes

using oldest-supported-numpy as build dependency

5c3ee47

See https://numpy.org/devdocs/user/troubleshooting-importerror.html#c-api-incompatibility

pastewka merged commit 36aeec0 into master Dec 20, 2022

pastewka deleted the 22_meson branch December 20, 2022 18:06

pastewka mentioned this pull request Dec 20, 2022

Add pyproject.toml and potentials change build system #116

Closed

jameskermode mentioned this pull request Dec 21, 2022

Update install instructions in README #125

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUILD: Switch to Meson for building #117

BUILD: Switch to Meson for building #117

pastewka commented Nov 29, 2022 •

edited

Loading

prs513rosewood commented Dec 13, 2022

prs513rosewood commented Dec 20, 2022

jameskermode commented Dec 20, 2022

jameskermode commented Dec 20, 2022 •

edited

Loading

jameskermode commented Dec 20, 2022

jameskermode commented Dec 20, 2022 •

edited

Loading

prs513rosewood commented Dec 20, 2022

jameskermode commented Dec 20, 2022 •

edited

Loading

BUILD: Switch to Meson for building #117

BUILD: Switch to Meson for building #117

Conversation

pastewka commented Nov 29, 2022 • edited Loading

prs513rosewood commented Dec 13, 2022

prs513rosewood commented Dec 20, 2022

jameskermode commented Dec 20, 2022

jameskermode commented Dec 20, 2022 • edited Loading

jameskermode commented Dec 20, 2022

jameskermode commented Dec 20, 2022 • edited Loading

prs513rosewood commented Dec 20, 2022

jameskermode commented Dec 20, 2022 • edited Loading

pastewka commented Nov 29, 2022 •

edited

Loading

jameskermode commented Dec 20, 2022 •

edited

Loading

jameskermode commented Dec 20, 2022 •

edited

Loading

jameskermode commented Dec 20, 2022 •

edited

Loading