Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEMSystem TimeSolver Fixes #1069

Merged
merged 7 commits into from Aug 25, 2016
Merged

FEMSystem TimeSolver Fixes #1069

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fe32f8b
Only call elem_fe_reinit in elem_reinit if there's mesh motion
pbauman Aug 24, 2016
45744d0
Add initial reinit_func(1.) call in Euler2Solver
pbauman Aug 24, 2016
0b40def
Add Euler2Solver unit test for second order
pbauman Aug 24, 2016
13f6fcb
Add NewmarkSolver setters for beta, gamma
pbauman Aug 24, 2016
48ecc26
Add reinit_func to NewmarkSolver, call in residual
pbauman Aug 24, 2016
0657125
Rework NewmarkSolverTest a bit
pbauman Aug 24, 2016
2dd3138
Add new NewmarkSolver unit test
pbauman Aug 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 13 additions & 11 deletions src/systems/fem_context.C
View file
Open in desktop
Expand Up @@ -1305,18 +1305,20 @@ void FEMContext::elem_reinit(Real theta)

// Handle a moving element if necessary.
if (_mesh_sys)
// We assume that the ``default'' state
// of the mesh is its final, theta=1.0
// position, so we don't bother with
// mesh motion in that case.
if (theta != 1.0)
{
// FIXME - ALE is not threadsafe yet!
libmesh_assert_equal_to (libMesh::n_threads(), 1);
{
// We assume that the ``default'' state
// of the mesh is its final, theta=1.0
// position, so we don't bother with
// mesh motion in that case.
if (theta != 1.0)
{
// FIXME - ALE is not threadsafe yet!
libmesh_assert_equal_to (libMesh::n_threads(), 1);

elem_position_set(theta);
}
elem_fe_reinit();
elem_position_set(theta);
}
elem_fe_reinit();
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but the doxygen comment for elem_reinit should probably be made clearer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean adding the note about setting the time?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I mean making it clearer that we're not reinitializing FE objects unless a moving mesh requires it.

Originally elem_reinit was supposed to reinitialize FE objects; and if you look at the documentation in DiffSystem that's clearly implied. It wasn't until later optimization that I broke out elem_fe_reinit() as a separate method.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I mean making it clearer that we're not reinitializing FE objects unless a moving mesh requires it.

Ah,OK.

Originally elem_reinit was supposed to reinitialize FE objects; and if you look at the documentation in DiffSystem that's clearly implied. It wasn't until later optimization that I broke out elem_fe_reinit() as a separate method.

Thanks for the clarification. I don't remember a time elem_fe_reinit wasn't called in the AssemblyContributions functor. But my memory has never been the same since my kids were born.



Expand Down