Fix missing includes found by test_installed_headers.sh #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When included alone, you apparently can't get away with just forward
declarations of TypeVector and TypeTensor. The error messages I was
getting were along the lines of:
In file included from /Users/petejw/projects/libmesh_git/installed/include/libmesh/exact_error_estimator.h:25:
/Users/petejw/projects/libmesh_git/installed/include/libmesh/function_base.h:136:18: error: implicit instantiation of undefined template 'libMesh::VectorValue<double>'
virtual Output component(unsigned int i,
^
/Users/petejw/projects/libmesh_git/installed/include/libmesh/function_base.h:77:11: note: in instantiation of member function 'libMesh::FunctionBase<libMesh::VectorValue<double> >::component' requested here
virtual ~FunctionBase ();
^
/opt/moose/llvm-3.9.0/bin/../include/c++/v1/memory:2541:13: note: in instantiation of member function 'libMesh::FunctionBase<libMesh::VectorValue<double> >::~FunctionBase' requested here
delete __ptr;
^
Refs libMesh#1593.
We use std::unique_ptr in this header, but it was only being included by accident on the main compilers we test with. Compiling with GCC 5.4.0 on Linux Mint 18 uncovered this issue. Refs libMesh#1594. Refs libMesh#1593.
This one just calls test_installed_headers.sh with specific arguments is useful in situations where you are not running "make installcheck".
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also includes a handy helper script which calls
test_installed_headers.shwith some useful arguments, since that script is designed to work with themake installchecktarget.Refs #1594.