Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print_helper using 3D vector argument #3381

Merged
merged 1 commit into from Aug 25, 2022

Conversation

miaoyinb
Copy link
Contributor

closes #3380

@miaoyinb
Copy link
Contributor Author

@GiudGiud FYI

@jwpeterson
Copy link
Member

FYI @miaoyinb I sent you an invite to join a group that has its PRs tested automatically. Note that some of the testing may fail currently due to a change that is present in libmesh upstream that is not compatible with MOOSE, we're hopeful that will be updated soon.

@moosebuild
Copy link

Job Coverage on e3d9b2a wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

@miaoyinb
Copy link
Contributor Author

FYI @miaoyinb I sent you an invite to join a group that has its PRs tested automatically. Note that some of the testing may fail currently due to a change that is present in libmesh upstream that is not compatible with MOOSE, we're hopeful that will be updated soon.

Got it. Thank you so much.

Copy link
Member

@roystgnr roystgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike that we're flattening the output here rather than using some kind of delimiter between different sub (and subsub) vectors ... but we're already flattening the vector<vector<P>> case, so at least we're consistent.

@roystgnr
Copy link
Member

The Test MOOSE failure is just "Test MOOSE python" again.

@roystgnr roystgnr merged commit b80b03b into libMesh:devel Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3D Vector Argument for libMesh::print_helper()
4 participants