Fix p=2 Lagrange nodal_soln on Tri7-sided elems #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I must have missed this because I still think of those elements as just ways to host Hierarchic bases, and although they need Lagrange support for mappings, we only hit nodal_soln when decimating solution variables for visualization.
This (when the fix is removed) triggers the bug I just fixed.
jwpeterson
approved these changes
Mar 19, 2024
|
CI failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I must have missed this because I still think of those elements as just
ways to host Hierarchic bases, and although they need Lagrange support
for mappings, we only hit nodal_soln when decimating solution variables
for visualization.
This fixes (and tests the fix for) the bug in #3794 (reply in thread)