Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiarch install location for cmake package config #1543

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gusnan
Copy link
Contributor

@gusnan gusnan commented Mar 20, 2024

Debians Multi-arch-hinter gives warnings for the cmake package config files installation directories - this should fix this. (For a comparison, checkout the folders /usr/lib/cmake/ and /usr/lib/x86_64-linux-gnu/cmake/ - there's a massive amount more using the x86_64-linux-gnu folder).

@SiegeLord
Copy link
Member

Do you know which version of cmake this became available? The internet also says that this comes from include(GNUInstallDirs), which we don't explicitly include anywhere.

@gusnan
Copy link
Contributor Author

gusnan commented Mar 21, 2024

Yeah, it looks to me it simply comes from GNUInstallDirs, so I guess the specific variable has been in cmake since that (which looks like around 3.0, somewhere around 2018). But you are right, I guess an include of GNUInstallDirs wouldn't hurt - I'll push a commit fixing this here.

@gusnan
Copy link
Contributor Author

gusnan commented Apr 17, 2024

Some post on the cmake forums that argues for ${CMAKE_INSTALL_LIBDIR}/cmake/<packageName> here: https://discourse.cmake.org/t/what-should-the-destination-be-for-a-header-only-librarys-cmake-config-file/8473/2?u=gusnan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants