Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenMPT support #1551

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add OpenMPT support #1551

wants to merge 1 commit into from

Conversation

SiegeLord
Copy link
Member

No description provided.

@pedro-w
Copy link
Contributor

pedro-w commented Apr 11, 2024

How do you disable DUMB in Cmake? All the other codecs seem to have a WANT_XXX variable, but not DUMB.

[edit] got it, it's WANT_MODAUDIO

@pedro-w
Copy link
Contributor

pedro-w commented Apr 12, 2024

How are you testing this? I tried using ex_acodec with some .mod files I have (and know to be ok) but the error dialog said "Could not load sample from 'XXX.mod'!" (nor did it work with the DUMB renderer on released version of A5 so I guess it's ex_acodec ?)

@SiegeLord
Copy link
Member Author

I compile it with both enabled, but hack it to use openmpt to load .xm files rather than DUMB. I generally use ex_stream_file with --loop or not. ex_stream_seek is also pretty good.

At the moment, I'm struggling to get looping to work, I don't really understand how openmpt handles looping (the only relevant APIs are openmpt_module_get_ctls with play.at_end and openmpt_module_set_repeat_count).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants