Fix writing of cpio archives containing hardlinks without file type #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kientzle
reviewed
May 29, 2020
| @@ -190,7 +190,7 @@ archive_write_newc_header(struct archive_write *a, struct archive_entry *entry) | |||
| const char *path; | |||
| size_t len; | |||
|
|
|||
| if (archive_entry_filetype(entry) == 0) { | |||
| if (archive_entry_filetype(entry) == 0 && archive_entry_hardlink_is_set(entry) == 0) { | |||
There was a problem hiding this comment.
This is the right idea, I think. We should keep this check, since people trying to create archives programmatically can easily overlook important bits. You might consider using archive_entry_hardlink(entry) == NULL as the test here (as is used a few lines below) instead of adding a new API.
There was a problem hiding this comment.
Oh, how did I miss that function? Thank you!
glebfm
force-pushed
the
tar2cpio-hardlink-filetype
branch
from
a24d243
to
84b27e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure.
May be we can just drop this check instead of touching API?